Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixd/tools/nixd-attrset-eval: support completion for "builtins" #620

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+193 −25
Draft

nixd/tools/nixd-attrset-eval: support completion for "builtins" #620

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f05b086
nixd/tools/nixd-attrset-eval: support completion for "builtins"
inclyc Nov 19, 2024
17db329
fixup
inclyc Nov 19, 2024
59f6dce
Update nixd/lib/Eval/AttrSetProvider.cpp
inclyc Nov 20, 2024
24792c1
add todo for getBuiltins
inclyc Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update nixd/lib/Eval/AttrSetProvider.cpp 
Co-authored-by: Jörg Thalheim <[email protected]>
  • Loading branch information
@inclyc @Mic92
inclyc and Mic92 authored Nov 20, 2024
commit 59f6dced100aafaf200c4c91bcd19089ee1b0e4a
2 changes: 1 addition & 1 deletion nixd/lib/Eval/AttrSetProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ std::vector<std::string> completeNames(nix::Value &Scope,
// FIXME: we may want to use "Trie" to speedup the string searching.
// However as my (roughtly) profiling the critical in this loop is
// evaluating package details.
// "Trie"s may not beneficial becausae it cannot speedup eval.
// "Trie"s may not beneficial because it cannot speedup eval.
for (const auto *AttrPtr : Scope.attrs()->lexicographicOrder(State.symbols)) {
const nix::Attr &Attr = *AttrPtr;
const std::string_view Name = State.symbols[Attr.name];
Expand Down
Loading