Skip to content

fix: use uid/gid 200 in container #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

fix: use uid/gid 200 in container #156

merged 1 commit into from
May 10, 2025

Conversation

kmendell
Copy link
Member

@kmendell kmendell commented May 10, 2025

Summary by CodeRabbit

  • Chores
    • Updated default user and group IDs for container environments from 1000 to 2000.

Copy link
Contributor

coderabbitai bot commented May 10, 2025

📝 Walkthrough

Walkthrough

The default values for the environment variables PUID and PGID were updated from 1000 to 2000 in both the Dockerfile and the entrypoint script. No other logic, control flow, or error handling was changed, and the DOCKER_GID variable remains unchanged.

Changes

Files Change Summary
Dockerfile, scripts/docker/entrypoint.sh Updated default values of PUID and PGID from 1000 to 2000.

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34dd97c and a9bc717.

📒 Files selected for processing (2)
  • Dockerfile (1 hunks)
  • scripts/docker/entrypoint.sh (1 hunks)
🔇 Additional comments (2)
Dockerfile (1)

29-29:

❓ Verification inconclusive

Confirm intended default UID/GID values.

You’ve updated the defaults to PUID=2000 and PGID=2000, but the PR title suggests you intended to use 200. Please verify whether the correct IDs should be 200 (as per the title) or 2000, and adjust these defaults to avoid permission mismatches in your container.


🏁 Script executed:

#!/bin/bash
# Fetch the PR title to confirm intended default UID/GID values
gh pr view --json title --jq .title

Length of output: 88


Confirm intended default UID/GID values

I wasn’t able to fetch the PR title automatically; please verify whether the defaults in your Dockerfile should be PUID=200/PGID=200 (per the PR title) or 2000/2000 as currently set. Update the ENV DOCKER_GID/PUID/PGID lines accordingly to avoid any permissions mismatches.

scripts/docker/entrypoint.sh (1)

14-15:

❓ Verification inconclusive

Verify default PUID/PGID in entrypoint script.

The script now sets PUID=${PUID:-2000} and PGID=${PGID:-2000}, but the PR title mentions using 200. Confirm the intended defaults and update these fallbacks accordingly to ensure the container user is created with the correct UID/GID.


Verify default PUID/PGID in entrypoint script

The fallbacks in scripts/docker/entrypoint.sh are currently set to:

PUID=${PUID:-2000}
PGID=${PGID:-2000}

However, the PR title indicates using 200 as the default UID/GID. Please confirm whether the intended defaults should be 200 (rather than 2000) and, if so, update these lines accordingly to ensure the container user is created with the correct UID/GID.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kmendell kmendell merged commit bae85ae into main May 10, 2025
4 checks passed
@kmendell kmendell deleted the fix/uid2000 branch May 10, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant