Skip to content

Updated the compatibility for UCM CMake macros #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trueqbit
Copy link

Raised the minimum required version of CMake to 3.5, but more importantly indicated the maximum known compatibility to be 3.31, which makes it kind of future-proof.

Raised the minimum required version of CMake to 3.5, but more importantly indicated the maximum known compatibility to be 3.31, which makes it kind of future-proof.
@sergio-nsk
Copy link
Contributor

sergio-nsk commented Mar 31, 2025

This change does not work with CMake 4.0.0
@trueqbit cotire/CMakeLists.txt and cotire/CMake/cotire.cmake also need this change.

CMake Error at third_party/ucm/cotire/CMake/cotire.cmake:40 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
Call Stack (most recent call first):
  third_party/ucm/cmake/ucm.cmake:19 (include)
  solid.cmake:158 (include)
  CMakeLists.txt:[37](https://github.com/snxd/client/actions/runs/14225339136/job/39863425460?pr=3066#step:6:38) (include)

@trueqbit
Copy link
Author

trueqbit commented Apr 2, 2025

This change does not work with CMake 4.0.0 @trueqbit cotire/CMakeLists.txt and cotire/CMake/cotire.cmake also need this change.

The problem is that cotire is a submodule.

@sergio-nsk
Copy link
Contributor

Perhaps, cotire should be removed.

@trueqbit
Copy link
Author

trueqbit commented Apr 3, 2025

@sergio-nsk Perhaps, cotire should be removed.

Well, I am not the maintainer of this repository and such a decision is beyond my competence I am afraid...
We currently only need the ucm.cmake file in sqlite_orm.

cotire seems to be used for providing unity builds, so it seems to be useful.
Perhaps a copy of cotire might be a solution? @nmoinvaz @onqtam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants