Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gitops addon manifests #419

Merged
merged 1 commit into from
Jan 23, 2025
Merged

add gitops addon manifests #419

merged 1 commit into from
Jan 23, 2025

Conversation

xiangjingli
Copy link
Collaborator

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-16762

Signed-off-by: Xiangjing Li <[email protected]>
@openshift-ci openshift-ci bot requested review from jnpacker and rokej January 23, 2025 18:18
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.96%. Comparing base (ad69346) to head (b03087f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   55.85%   55.96%   +0.11%     
==========================================
  Files          96       96              
  Lines       15742    15742              
==========================================
+ Hits         8792     8810      +18     
+ Misses       6068     6044      -24     
- Partials      882      888       +6     
Flag Coverage Δ
unit 55.96% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Maybe some e2e can come later?

Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli
Copy link
Collaborator Author

Yeah, the PR is created first for installer double check. Later Another PR will be delivered to multicloud-integration repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants