Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat2/josep #570

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat2/josep #570

wants to merge 3 commits into from

Conversation

josep-b
Copy link

@josep-b josep-b commented Nov 9, 2024

Description

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Contributors Checklist

I've read through the Getting Started section

  • βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

Screenshot 2024-11-09 at 11 52 06β€―AM

[optional] What GIF best describes this PR or how it makes you feel?

@josep-b josep-b requested a review from a team as a code owner November 9, 2024 17:09
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @josep-b,

Thank you for your contribution! ✨

There are several things here:

  • You have failed checks that you need to address before we can review your PR. Please fix each of them until all checks pass.

  • You need to complete your PR template. We can't review your PR if it's not completed.

  • You have three issues open. Please close two of them and keep the one you want to keep.

Let me know once you've fixed them and if you have questions or need help.

Thank you. πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants