Skip to content

feat: Add reasoning item handling to skip non-message content #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ygbingo
Copy link

@ygbingo ygbingo commented Jul 17, 2025

Summary

This PR aims to resolve #1164. In issue #1164, the problem [describe the problem briefly] was reported. This PR provides a solution by [explain the main changes you made to solve the problem].

Test plan

To ensure the effectiveness of the changes, the following test plan was implemented:

  1. Unit tests: New unit tests were added to cover the modified functions and classes. These tests verify the correct behavior of the code under different input scenarios.
  2. Integration tests: Integration tests were run to ensure that the changes do not break the existing functionality of the SDK. The full test suite was executed, and all tests passed successfully.
  3. Manual testing: Manual testing was also performed to validate the changes in a real-world scenario. The [describe the specific operations in manual testing] was tested, and the results were as expected.

Checks

  • I've added new tests (if relevant)
  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

Additional notes

If there are any other relevant details or considerations, such as potential impacts on other parts of the codebase, limitations of the solution, or future improvements, please mention them here.

@dotmobo
Copy link

dotmobo commented Jul 17, 2025

+1

Would be cool to get the <think> content somehow.
But if this fix stops the whole message from blowing up, that’s already a win.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled item type or structure with resoning item
3 participants