-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-17257: chore(tests): add testcontainers test to check Rmd to PDF rendering in RStudio #857
RHOAIENG-17257: chore(tests): add testcontainers test to check Rmd to PDF rendering in RStudio #857
Conversation
… PDF rendering in RStudio
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dst="/scripts") | ||
|
||
# copy to a (writable) working directory | ||
check_call(container, "bash -c 'cp /scripts/document.Rmd ./'") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of copying this again, wouldn't it be better to copy these files to the final directory right away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good point, fixed it now
/override ci/prow/images
return rc | ||
|
||
|
||
def check_output(container: WorkbenchContainer, cmd: str) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method and the check_call
above seem both quite generic - maybe we should consider to put them on some common place... I don't insist to do this in this PR, but maybe eventually...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
243002d
to
30f52fa
Compare
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm thank you |
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1540ee2
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-17257
Description
How Has This Been Tested?
This passes with
and fails with
with error that's beginning the same as what's in the screenshot that @shalberd reported in
Merge criteria: