bugfix: mark committed to false only when it is nil in conn #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging the conn limiter today, I tried with this code in development env, to help me get conn counter value in HTTP header:
And surprised by that, after I added the
limiter:incoming(keys[i], false)
here, thelimiter:is_committed()
returns false even when it is actually committed.In
conn.md
, it says:But it is actually not just "dry run" --
incoming
would always set committed to false at first not matter what.This PR tries to fix the lua code to align with docs, and adds a testcase for that.