Bump spdlog to v1.9.0 #4067
Open
Bump spdlog to v1.9.0 #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbianco
requested review from
aymanhab and
adamkewley
and removed request for
aymanhab and
adamkewley
|
Thanks @nickbianco the change seems reasonable LGTM but the tests are failing |
aymanhab
reviewed
Apr 24, 2025
There was a problem hiding this comment.
Approved pending fix to ci build failures as there's no actual code to review
Reviewable status: 0 of 2 files reviewed, all discussions resolved
|
@aymanhab unfortunately this led to a new error on Ubuntu: This issue seems like it was fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4066
Brief summary of changes
Bumps the
spdlogdependency to version1.9.0, which bundles a more recent version offmt(v7.1.3) and includes support forfmtv8.x. This version also fixes a warning observed in #4066 when building with C++20 resulting in a deprecated implicit copy assignment operator warning.Testing I've completed
Built locally on M3 MacBook with:
Looking for feedback on...
Will this lead to any unforeseen issues in downstream libraries or cause backwards compatibility issues?
CHANGELOG.md (choose one)
This change is