Skip to content

Opensim 452 linux rpath #4071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2025
Merged

Opensim 452 linux rpath #4071

merged 2 commits into from
May 4, 2025

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented May 4, 2025 •
edited
Loading

Fixes issue opensim-org/conda-opensim#44

Brief summary of changes

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because build system, not user facing

This change is Reviewable

@aymanhab aymanhab requested a review from nickbianco May 4, 2025 15:51
nickbianco
nickbianco approved these changes May 4, 2025
View reviewed changes
Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice find!

I wonder why the "AND LINUX" conditional was failing on Ubuntu there.

@aymanhab
Copy link
Member Author

aymanhab commented May 4, 2025

Thanks @nickbianco 👍 Apparently CMake doesn't define LINUX only UNIX and APPLE 🤷

@aymanhab aymanhab merged commit 97aec58 into opensim_452 May 4, 2025
10 checks passed
@nickbianco
Copy link
Member

LINUX does exist, but only for CMake version 3.25 or later. I was the one who added the conditional, not realizing that my local CMake was higher than the minimum we require (3.15). Good find!

@nickbianco nickbianco mentioned this pull request May 5, 2025
Closed
@nickbianco nickbianco deleted the opensim_452_linux_rpath branch May 5, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickbianco nickbianco nickbianco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanhab @nickbianco