Better preview titles #4272
Merged
Better preview titles #4272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structs and templates, hardcode 0 for r::content_response - need to fix, WIP ordinals#4264
…sponse function signature, and set to 0 in tests
raphjaph
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better titles to preview pages (per #4264)
In this solution,
inscription_numberis fetched from the index entry where necessary, and passed to the preview structs and templates, to be used as part of the HTML title tags, respectively. Note alsoinscription_numberis added to ther::content_responsefunction signature, to be able to be passed toPreviewIframeHtml, and explicitly set to 0 in tests.