spqr-ping

[Denchick]

The main idea is to add a fast ping handler without tls requirements.

➜  spqr git:(ping-idea) ✗ psql "host=localhost port=8432 dbname=spqr-ping user=spqr-ping sslmode=disable"
psql (14.17 (Homebrew), server 0.0.0)
Type "help" for help.

spqr-ping=> --fweq;
spqr-ping=> ;
spqr-ping=?> ;
no connection to the server
The connection to the server was lost. Attempting reset: Succeeded.
psql (14.17 (Homebrew), server 0.0.0)
spqr-ping=> qwef;
spqr-ping=?> fweqf;
no connection to the server
The connection to the server was lost. Attempting reset: Succeeded.
psql (14.17 (Homebrew), server 0.0.0)
spqr-ping=> ;fqwe
spqr-ping-?> ;fqw
no connection to the server
The connection to the server was lost. Attempting reset: Succeeded.
psql (14.17 (Homebrew), server 0.0.0)
spqr-ping-> 

[Copilot]

Pull Request Overview

This PR introduces a fast ping handler that bypasses TLS requirements for quick health checks.

• Added ping detection logic in the router to route “spqr-ping” requests to a dedicated ping handler.
• Introduced a new preRoutePingPong function to assign the ping rule and process ping requests.
• Implemented a Ping method in the client interactor to send back a “pong” response.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
router/rulerouter/rulerouter.go	Added debug logging and ping detection logic along with a dedicated preRoutePingPong function.
router/instance/instance.go	Extended connection handling to process ping requests and send appropriate backend messages.
pkg/clientinteractor/interactor.go	Implemented the Ping method to handle ping requests by writing header and data row messages.

[Copilot]

Pull Request Overview

This PR introduces a fast ping handler for connections with "spqr-ping" that bypasses TLS checks. Key changes include:

• Routing logic updates to detect "spqr-ping" in both the RuleRouter and Instance implementations.
• Implementation of a new preRoutePingPong function to assign rules and handle ping-specific authentication.
• An added ReadyForQuery method in the PSQLInteractor for sending backend messages during ping.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
router/rulerouter/rulerouter.go	Adds spqr-ping routing support via preRoutePingPong function.
router/instance/instance.go	Integrates spqr-ping handling by sending ping messages and processing responses.
pkg/clientinteractor/interactor.go	Introduces a new ReadyForQuery method for ping response handling.

[Denchick]

It works

spqr-ping=> gqwe;
SPQR router is alive

spqr-ping=> fwqe;
SPQR router is alive

spqr-ping=> weqf;
SPQR router is alive

spqr-ping=> --qwef;
spqr-ping=> wegf;
SPQR router is alive

spqr-ping=> ;
SPQR router is alive

spqr-ping=> ;
SPQR router is alive

spqr-ping=> qwef;
SPQR router is alive

[Denchick]

Take into account sslmode:

root@regress_tests:/regress# psql "host=regress_router port=6432 user=spqr-ping dbname=spqr-ping sslmode=disable"
SPQR router is alive
psql (13.20 (Ubuntu 13.20-1.pgdg20.04+1), server 0.0.0)
Type "help" for help.

spqr-ping=> gqwefrq;
SPQR router is alive

spqr-ping=> \c spqr-console
connection to server at "regress_router" (172.18.0.8), port 6432 failed: ERROR:  SSL IS REQUIRED
Previous connection kept
spqr-ping=>