Category cleanups and alignments (Second try) #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix #95 - category cleanups - follow "private - something" instead of "private something" - have class side #initialize in "class initialization" instead of "initialization" (applied via autofix) - remove dots at end of methods - formatting - better temp names ("mem" -> "memory") - review lint rules and ban when no violation - add ^ for the subclassResponsibility in every #expectedXXX method - remove unnecessary method comments in TonelFileSystemUtils>>#initialize (we have an icon to click) - add chaining for a few cases - method comments to start uppercase (like a sentence)
- better temp name ("mem" -> "memory")
- review all methods and ban a few rules when we can ignore them (long methods and other)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement PR for #96 to fix #95 where now all tests should be green now