fix: expose an internal function for devtools #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/8W3TMTSAJ |
See documentations for usage instructions.
|
Size Change: +249 B (+0.26%) Total Size: 97.6 kB
ℹ️ View Unchanged
|
arjunvegda
approved these changes
Apr 13, 2025
arjunvegda
reviewed
Apr 13, 2025
Comment on lines
+89
to
+94
| export function INTERNAL_overrideCreateStore( | ||
| fn: (prev: typeof createStore | undefined) => typeof createStore, | ||
| ): void { | ||
| overiddenCreateStore = fn(overiddenCreateStore) | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we export it out of jotai/vanilla too?
There was a problem hiding this comment.
Yeah, I forgot there was a follow-up commit. Thanks.
arjunvegda
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
#3023
Summary
This allows overriding createStore. It's not very recommended, but can't be helped to avoid breaking changes. We may revisit this in the next major version. cc @arjunvegda
Check List
pnpm run fixfor formatting and linting code and docs