-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Allow casting List<UInt8> to Binary #22611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow casting List<UInt8> to Binary #22611
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22611 +/- ##
========================================
Coverage 80.99% 81.00%
========================================
Files 1661 1664 +3
Lines 234867 235162 +295
Branches 2772 2773 +1
========================================
+ Hits 190234 190490 +256
- Misses 43965 44004 +39
Partials 668 668 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Should be fixed by #22613. |
It should be possible to construct the There is also a simple optimization we should do where if at the end of construction we see that all |
@nameexhaustion I did this, and then realized it's a problem insofar as a |
@nameexhaustion OK implemented both ideas. |
Thank you for the review, I've addressed the comments. |
Will figure out failing tests tomorrow morning. |
The test is failing because the buffer is now dropped as all the views are in-lined - we should add specific test to assert that there are no data buffers in the result array for the case when all views are inlined. For the test to ensure proper buffer splitting, the max buffer size limit needs to be increased. |
Co-authored-by: Itamar Turner-Trauring <[email protected]>
Fixes #21549.