Skip to content

Commit

Permalink
rename user-queue to default-queue to match mlbatch conventions (#274)
Browse files Browse the repository at this point in the history
  • Loading branch information
dgrove-oss authored Nov 27, 2024
1 parent 256dbab commit 8262f05
Show file tree
Hide file tree
Showing 14 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion hack/default-queues.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
namespace: "default"
name: "user-queue"
name: "default-queue"
spec:
clusterQueue: "cluster-queue"
4 changes: 2 additions & 2 deletions internal/webhook/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ var cancel context.CancelFunc

const limitedUserName = "limited-user"
const limitedUserID = "8da0fcfe-6d7f-4f44-b433-d91d22cc1b8c"
const defaultQueueName = "default-queue"
const userProvidedQueueName = "user-queue"
const defaultQueueName = "system-default-queue"
const userProvidedQueueName = "user-provided-queue"

func TestWebhooks(t *testing.T) {
RegisterFailHandler(Fail)
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-deployment
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
spec:
components:
- template:
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-failing-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-failing-job
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
annotations:
workload.codeflare.dev.appwrapper/failureGracePeriodDuration: 10s
workload.codeflare.dev.appwrapper/retryPausePeriodDuration: 10s
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-failing-pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-failing-pod
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
annotations:
workload.codeflare.dev.appwrapper/failureGracePeriodDuration: 10s
workload.codeflare.dev.appwrapper/retryPausePeriodDuration: 10s
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-failing-pytorch-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-failing-pytorch-job
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
spec:
components:
- template:
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-gpu-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-gpu-job
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
annotations:
workload.codeflare.dev.appwrapper/successTTLDuration: "1m"
spec:
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-job
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
annotations:
workload.codeflare.dev.appwrapper/successTTLDuration: "1m"
spec:
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-pod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-pod
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
spec:
components:
- template:
Expand Down
2 changes: 1 addition & 1 deletion samples/wrapped-pytorch-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: AppWrapper
metadata:
name: sample-pytorch-job
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
spec:
components:
- template:
Expand Down
2 changes: 1 addition & 1 deletion site/_pages/dev-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ You can verify Kueue is configured as expected with:
```sh
% kubectl get localqueues,clusterqueues -o wide
NAME CLUSTERQUEUE PENDING WORKLOADS ADMITTED WORKLOADS
localqueue.kueue.x-k8s.io/user-queue cluster-queue 0 0
localqueue.kueue.x-k8s.io/default-queue cluster-queue 0 0

NAME COHORT STRATEGY PENDING WORKLOADS ADMITTED WORKLOADS
clusterqueue.kueue.x-k8s.io/cluster-queue BestEffortFIFO 0 0
Expand Down
2 changes: 1 addition & 1 deletion site/_pages/quick-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
namespace: "default"
name: "user-queue"
name: "default-queue"
spec:
clusterQueue: "cluster-queue"
```
Expand Down
2 changes: 1 addition & 1 deletion site/_pages/sample-batch-job.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ kind: AppWrapper
metadata:
name: sample-job
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
spec:
components:
- template:
Expand Down
2 changes: 1 addition & 1 deletion site/_pages/sample-pytorch.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ kind: AppWrapper
metadata:
name: sample-pytorch-job
labels:
kueue.x-k8s.io/queue-name: user-queue
kueue.x-k8s.io/queue-name: default-queue
spec:
components:
- template:
Expand Down

0 comments on commit 8262f05

Please sign in to comment.