Test Instascale machine set functionality

[Fiona-Waters]

Issue link

Closes #323

What changes have been made

An e2e test has been added to test the entire instascale flow on an OCP Cluster - testing machine set functionality.

Verification steps

• Provision an OCP cluster
• Install the codeflare stack following the Quick Start.
• A NodeFeatureDiscovery CR and ClusterPolicy CR are required also. These can be added using the updated makefile - if installing using make all-in-one these should already be present. NFD and ClusterPolicy.
• Set instascale: enabled: false in the Codeflare Operator config map and deploy Instascale from this image: quay.io/rh_ee_fwaters/instascale-controller:CRtest which uses this PR. Add an Instastale configMap stating a max scale out value like so:

kind: ConfigMap
apiVersion: v1
metadata:
  name: instascale-config
  namespace: instascale-system
data:
  maxScaleoutAllowed: '5'

• Create a machineSet in the cluster following instructions here. setting the ami id to ami-0624891c612b5eaa0.
• In your VS code terminal log in to your cluster.
• Run or Debug the test.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[sutaakar]

/lgtm

[astefanutti]

Is it OK to have openshift-machine-api hard-coded?

[astefanutti]

Could passing the label selector as argument instead be useful?

[Fiona-Waters]

I'm not sure if we can access the machine label easily in the test to pass it in. Could this work, or what would be the benefit of passing it as an argument? maybe it can be one variable instead of 2 also since these shouldn't change.

labelSelectorPrefix = "machine.openshift.io/cluster-api-machineset="
machine, err := t.Client().Machine().MachineV1beta1().Machines(namespaceToList).List(t.Ctx(), metav1.ListOptions{LabelSelector: labelSelectorPrefix + machineSetName})

[astefanutti]

You're right, probably bette to keep it that way for now.

[astefanutti]

/lgtm

[astefanutti]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment