Fix proxy handling issues in Nuclei #6099

Likhithsai2580 · 2025-03-16T08:17:53Z

Related to #6029

Address proxy handling issues in Nuclei to respect concurrency settings and improve request speed.

internal/runner/proxy.go
- Add logic to handle concurrency settings for proxy servers.
- Ensure proxy settings respect concurrency values.
internal/runner/runner.go
- Initialize the HTTP client with proxy settings and ensure concurrency is respected.
- Add logic to handle concurrency settings for proxy servers.
pkg/protocols/http/httpclientpool/clientpool.go
- Manage HTTP client pooling and enforce concurrency settings with proxies.
- Ensure proxy settings respect concurrency values.

Summary by CodeRabbit

Refactor
- Optimized internal handling of concurrent operations for improved reliability.
- Streamlined configuration saving processes to maintain consistency without affecting user-facing functionality.

Related to projectdiscovery#6029 Address proxy handling issues in Nuclei to respect concurrency settings and improve request speed. * **internal/runner/proxy.go** - Add logic to handle concurrency settings for proxy servers. - Ensure proxy settings respect concurrency values. * **internal/runner/runner.go** - Initialize the HTTP client with proxy settings and ensure concurrency is respected. - Add logic to handle concurrency settings for proxy servers. * **pkg/protocols/http/httpclientpool/clientpool.go** - Manage HTTP client pooling and enforce concurrency settings with proxies. - Ensure proxy settings respect concurrency values.

coderabbitai · 2025-03-16T08:18:03Z

Walkthrough

This pull request introduces two internal improvements. In the proxy module, the loadProxyServers function now checks if options.Concurrency is above zero and uses an atomic.Int32 variable to manage the concurrency setting safely. In the runner module, the SaveResumeConfig method has been updated to reassign an already declared data variable instead of using a short variable declaration during JSON marshaling.

Changes

File Path	Summary of Changes
internal/runner/proxy.go	Updates `loadProxyServers` to check `options.Concurrency` and uses `atomic.Int32` for thread-safe management. Adds the `sync/atomic` import.
internal/runner/runner.go	Modifies `SaveResumeConfig` to reassign the previously declared `data` variable with the JSON marshaling result instead of redeclaring it.

Suggested reviewers

dogancanbakir
ehsandeep

Poem

I hopped through lines of code today,
Ensuring threads in harmony at play,
With atomic leaps, the numbers hold tight,
And data flows true, clean and right.
A bunny’s cheer for improvements so bright! 🐰

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/runner/runner.go (1)
879-879: Fixed variable assignment syntax

The change from using short variable declaration (:=) to standard assignment (=) is correct if data was previously declared in this scope. This prevents the unintended creation of a new variable in a nested scope.

However, consider adding error handling for the JSON marshaling operation instead of ignoring it with _.
-data, _ = json.MarshalIndent(resumeCfgClone, "", "\t")
+data, err := json.MarshalIndent(resumeCfgClone, "", "\t")
+if err != nil {
+    return fmt.Errorf("failed to marshal resume config: %w", err)
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01e5cae and 8b32162.

📒 Files selected for processing (2)

internal/runner/proxy.go (2 hunks)
internal/runner/runner.go (1 hunks)

🔇 Additional comments (1)

internal/runner/proxy.go (1)

66-71: Good use of atomic operations for thread safety

The addition of atomic operations to ensure proxy settings respect concurrency values is a good practice. Using atomic.Int32 provides thread-safe access to the concurrency value in a multi-threaded environment, which is important when dealing with proxy configurations.

GeorginaReeder · 2025-03-17T12:34:14Z

Thanks so much for your contribution @Likhithsai2580 , we appreciate it!

Mzack9999

@Likhithsai2580 Thanks for your PR. How this exactly fixes the linked issue? From the code it seems like it's just overwriting options.Concurrency with itself

auto-assign bot requested a review from dwisiswant0 March 16, 2025 08:17

coderabbitai bot reviewed Mar 16, 2025

View reviewed changes

dwisiswant0 requested a review from Mzack9999 April 3, 2025 09:12

Mzack9999 requested changes Apr 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix proxy handling issues in Nuclei #6099

Fix proxy handling issues in Nuclei #6099

Likhithsai2580 commented Mar 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 16, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

GeorginaReeder commented Mar 17, 2025

Mzack9999 left a comment •

edited

Loading

Fix proxy handling issues in Nuclei #6099

Are you sure you want to change the base?

Fix proxy handling issues in Nuclei #6099

Conversation

Likhithsai2580 commented Mar 16, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Mar 16, 2025 • edited Loading

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

GeorginaReeder commented Mar 17, 2025

Mzack9999 left a comment • edited Loading

Choose a reason for hiding this comment

Likhithsai2580 commented Mar 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Mzack9999 left a comment •

edited

Loading