-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: add EnableMatcherStatus function to configure matcher status in… #6191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughA new function, Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/config.go (1)
466-473
: Add documentation and unit tests for the new option
TheEnableMatcherStatus
function correctly follows the existing SDK option pattern, but we currently lack any tests or user‐facing documentation for this new flag. Consider:
- Adding a unit test (e.g. in
sdk_config_test.go
) to assert thate.opts.MatcherStatus
is set totrue
.- Updating CLI docs or
README.md
to document thematcher-status
flag and its behavior.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/config.go
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
lib/config.go (1)
lib/sdk.go (2)
NucleiSDKOptions
(33-33)NucleiEngine
(55-88)
Thanks for your contribution @egru :) As a token of appreciation for your valuable contribution, you can grab some cool PD Stickers from here http://nux.gg/stickers. We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments! |
I can't pass up stickers! |
Proposed changes
added matcherstatus flag for NucleiSDKOptions
Checklist
Summary by CodeRabbit