Add geopandas stubs #12990
Draft
Add geopandas stubs #12990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Not sure about the stub uploader failure. It is complaining about pandas-stubs while it should be complaining about pyproj. |
hamdanal
added a commit
to hamdanal/stub_uploader
that referenced
this pull request
Nov 10, 2024
This is an important dependency of geopandas which I am adding to typeshed in python/typeshed#12990. It is in the top 1000 PyPI packages https://hugovk.github.io/top-pypi-packages/
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandera (https://github.com/pandera-dev/pandera)
+ tests/geopandas/test_geopandas.py:62: error: Type application targets a non-generic function or class [misc]
+ tests/geopandas/test_geopandas.py:66: error: Type application targets a non-generic function or class [misc]
+ tests/geopandas/test_geopandas.py:110: error: Type application targets a non-generic function or class [misc]
+ tests/geopandas/test_geopandas.py:113: error: Type application targets a non-generic function or class [misc]
+ tests/geopandas/test_geopandas.py:159: error: Type application targets a non-generic function or class [misc]
+ tests/geopandas/test_geopandas.py:162: error: Type application targets a non-generic function or class [misc]
+ tests/geopandas/test_geopandas.py:289: error: Type application targets a non-generic function or class [misc]
+ tests/geopandas/test_geopandas.py:292: error: Type application targets a non-generic function or class [misc]
|
|
Looks like stub_uploader is checking if pandas-stubs is a dependency of the runtime package instead of checking for pandas. @srittau do you think we can change stub_uploader to look for pandas in the runtime dependencies whenever it sees pandas-stubs used in a typeshed typing package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are basically copied over from hamdanal/python-stubs. I've been using them for a while with Pylance and fixing them along the way, hopefully they are of good quality. I've also written some tests in the original repo that I did not include in the PR but might consider using some of them later if we find it necessary.