Add TransIP provider #921
Open
Add TransIP provider #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeertJohan
reviewed
Mar 29, 2025
|
I've tested this PR and it seems to work good :) |
|
@GeertJohan Thanks for testing and the suggestion! I'll try to update the PR somewhere next week to include the suggestion and get it fully ready :) |
|
Took a bit longer than expected, but the suggestion is now part of the code, and all seems to be working well still :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for TransIP, resolves #254
Tested locally, and seemed to work like a charm! Ipv6 and wildcards are both supported, and it will either create a new entry, or update an existing one.
The relevant API documentation can be found here: https://api.transip.nl/rest/docs.html#domains-dns
Side note: this PR also includes a small fix from #918. It shouldn't conflict, but if that does happen I'll fix that after that one is merged :)
Let me know if any changes are needed, and thanks in advance!