new form: My Workshops

[jaredwould]

broken

• submitting new rerun broke my workshops view
• hitting enter when adding new location submits whole form. would be nice if hitting enter in this field submitted only that field. Or if any field submitted enter.

ben first priority

• always display 3 most recent reruns
• do not display message button with no RSVP model
• if RSVP model, display
• put lock/delete on the left
• remove edit icon for reruns (they can click link, maybe we should make link more obvious)
• "+ New series" button should present the events#edit form and auto-create the workshop
• if easy, unset prefilled date/time when user creates first rerun and let's require them to select it before creating first rerun. if lots of work, punt for now.
• take off manage button from My Workshops

second priority

• allow collapse of older reruns

jareds priority

• is there a workshop creation confirmation email? if so, update copy and include links to edit, alerts, messages, and manage pages in this email.
• change copy of popup from +New Series button
• combine and mockup attendees and messaging

[bteitelb]

This is a specific set of unfinished business from #14

[bteitelb]

The functionality of the "+ New series" button is not correct either: it should present the events#edit form and auto-create the workshop. I've edited the checklist above to reflect this.

[jaredwould]

yes, we're looking at it now and recording things to change

[jaredwould]

we see what you're saying about +New Series.

[ratacat]

here is the error that gets logged on myworkshops#view after a new series/rerun is created...

ActionView::Template::Error (undefined method first_meeting' for nil:NilClass): 1: <% 2: event ||= @event 3: first_meeting = event.first_meeting 4: %> 5: <div class="row"> 6: <div class="col-md-8"> app/views/events/_simple_host_row.html.erb:3:in_app_views_events__simple_host_row_html_erb___1835285640156685506_69961709839200'
app/views/workshops/_index.html.erb:15:in block in _app_views_workshops__index_html_erb___2085907672114284638_69961705883040' app/views/workshops/_index.html.erb:6:ineach'
app/views/workshops/_index.html.erb:6:in _app_views_workshops__index_html_erb___2085907672114284638_69961705883040' app/views/workshops/my_workshops.html.erb:9:in_app_views_workshops_my_workshops_html_erb___3094749004380895810_69961705607180'
app/controllers/workshops_controller.rb:15:in `my_workshops'

[bteitelb]

That error is fixed now.

[bteitelb]

Regarding "hitting enter when adding new location submits whole form. would be nice if hitting enter in this field submitted only that field. Or if any field submitted enter", I designed it that way. I thought we were trying to get away from sub-forms and fidgety AJAX that auto-submits.

[bteitelb]

What does "always display 3 most recent reruns" mean? You guys previously asked for the last rerun plus all upcoming reruns. Does this mean "last 3 past reruns, plus all upcoming reruns"?

[bteitelb]

OK, please test this stuff on the dev server. Although it's not all there, it's much better than what's currently deployed on production. If you guys don't find any show-stoppers, I think we should deploy.

[bteitelb]

Have you guys tested this? Can I deploy it?

[jaredwould]

I don't think any of these are quite showstoppers, but there are some wonkies. I think still hold off on deploy, especially while emails and messaging seems broken. I'll keep testing iterations as I can, resuming next week, 3/30, and we can assume @ratacat won't be testing unless he says he's going to.

general

• anyone should be able to post. “my workshops” doesn’t show up for non-hosts [ok, but that's no different from how it is today ahh that was unclear; all users should see my workshops on menu when they click their name, and have the ability to post]
• reruns that all ready have occurred should not be editable [ok, the current rule is that any rerun that was attended cannot be edited ahh, that makes sense, i didn't realize whichever i checked didn't have any attendees, don't worry about this]
• display address publicly not functional when selected “yes” [oops]

email? [all email is probably broken on staging; I think I disabled it when we were having the trouble with Sendgrid ahh right. funky test server assymetries... perhaps best to test after its deployed to regular server]

• email doesn't seem functional
• no email to create account when tried to sign up as not-logged-in user then filled in modal with existing account email [email protected]
• no confirmation email when [email protected] signed up for Game 1 of The World Series

My Workshops

• change "+schedule new rerun in series” button to "+add activity to series" [ok]

Index View

Rerun View

• clicked sign up when not signed in, entered existing account in modal, and it said it sent me a new confirmation email. ideally it would recognize existing account and send me to sign in page [will investigate]
• edit button in host panel leads to Alerts

Message Attendees

• long message all failed with error “trouble saving message” [will investigate]

Edit

• uploading image seems that it works, and does update within edit workshop, but does not update in workshop view nor index view
  —> possibly useful info: uploading image through host panel on rerun view works.

[bteitelb]

@jaredwould I've added some replies inline above in square brackets.

[jaredwould]

i replied in italics within your bracketed comments

On Mon, Mar 23, 2015 at 10:03 PM, bteitelb [email protected] wrote:

@jaredwould https://github.com/jaredwould I've added some replies
inline above in square brackets.

—
Reply to this email directly or view it on GitHub
#64 (comment).

[bteitelb]

Re: "anyone should be able to post", are you guys sure about that? The first spammer to discover this could fill the site with "buy cialis online!!!" spam.

[bteitelb]

OK, I tried to fix display address publicly not functional when selected “yes” and realized I am officially confused about the interaction of "Display address publicly?", "Limit RSVPs", and attendance.

The way it is today, if an event is not RSVP, there is no sign-up and the address is shown publicly. And, if an event is RSVP, the address is shown to attending users once they are signed up.

What then does "Display address publicly?" mean? Suppose both "Display address publicly?" and "Limit RSVPs" are both set to NO, how would anyone ever learn of the address?

If that toggle still makes sense, please explain under what conditions an address should be shown by completing the last column of this table:

"Display address publicly?"	"Limit RSVPs"	Attending	Should address be displayed?
Y	Y	Y
Y	Y	N
Y	N	Y
Y	N	N
N	Y	Y
N	Y	N
N	N	Y
N	N	N

[bteitelb]

Some notes after discussing with @ratacat :

• Rename first switch to: "Always show address?"
• Rename second switch to: "Require RSVP?"

Then the logic is:

"Always show address?"	"Require RSVP?"	Attending	Should address be displayed?
Y	Y	Y	Y
Y	Y	N	Y
Y	N		Y
N	Y	Y	Y
N	Y	N	N
N	N		N