-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add add-platform
command
#2298
base: main
Are you sure you want to change the base?
Conversation
f55ce07
to
fda027b
Compare
cc @kelset @tido64 @Saadnajmi would love to hear your thoughts about it 🙏 |
looping in also @acoates-ms and @chrisglein who might be interested in this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor comments, overall lgtm 👍
At its current point, this doesn't work with React Native Windows or macOS, correct? Has this been tested maybe with some local changes to a clone of RNM/RNW to see how well it works? I think it's harder for me to give any feedback (at least macOS specific) without seeing an end to end use case (other than visionOS :P ) |
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
ff9545e
to
4827e7f
Compare
Summary:
In this Pull Request I've added new command
add-platform
which re-uses code frominit
command to add a new OOT platform to existing React Native app. It gets React Native version frompackage.json
and it tries to find a matching platform's version from NPM registry. Then, if successful it reuseseditTemplate
functions to replace placeholders.demo.mp4
For OOT platforms to add a compatibility with the new command:
platforms
insidetemplate.config.js
, which is an array in which OOT platform should provide names of folders containing native code. e.g.platforms: ["macos"]
postInitScript
(also undertemplate.config.js
) with e.g. installing Pods and printing run instructions.packages/react-native/template${platformName}
.Checklist