Skip to content

mismatch between the streaming logs that we get from azure-ai-ml and the log file we download at the end #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 24, 2025

Conversation

miguelgfierro
Copy link
Collaborator

@miguelgfierro miguelgfierro commented Apr 21, 2025

Description

Related to #2222 (comment)

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Signed-off-by: miguelgfierro <[email protected]>
@SimonYansenZhao
Copy link
Collaborator

SimonYansenZhao commented Apr 22, 2025

@SimonYansenZhao
Copy link
Collaborator

The latest log downloaded via azure mlflow in the run triggered last week

Screenshot 2025-04-22 at 10 47 00

is the same as the log 3 months ago

Screenshot 2025-04-22 at 10 39 15

@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Apr 23, 2025

After I changed azureml-related packages to older versions:

@SimonYansenZhao but where is the problem coming from? Is it azure-ai-ml or mlfow?

I'm going to try a few combinations:

@SimonYansenZhao
Copy link
Collaborator

I don't think the problem is from mlflow because mlflow only defines the universal interfaces for azure-ai-ml to use. mlflow doesn't know how to get the logs from AzureML workspace but azure-ai-ml knows.

Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Apr 23, 2025

@SimonYansenZhao please review the tests I've made. At the end, the solution I found it works is: pip install "azure-ai-ml>=1.26.4,<2" "azureml-mlflow>1,<2"
See https://github.com/recommenders-team/recommenders/actions/runs/14619686582/job/41018376740

Let me know if you think it is ok, and we can merge this. Then there are a few other bugs we need to fix on a different PR.

@SimonYansenZhao
Copy link
Collaborator

@miguelgfierro OK, let's merge it.

By looking at what you changed, I find the latest azure-ai-ml is used (i.e., 1.26.4, released just yesterday). It looks like the mismatched log issue is from the AzureML side, and they were aware of the issue and fixed it yesterday.

Screenshot 2025-04-24 at 14 17 38

@SimonYansenZhao
Copy link
Collaborator

The new issues, I think, may have something to do with the out-dated surprise package.

@miguelgfierro
Copy link
Collaborator Author

@miguelgfierro OK, let's merge it.

ok merging

@miguelgfierro miguelgfierro merged commit 40ecca0 into staging Apr 24, 2025
3 of 112 checks passed
@miguelgfierro miguelgfierro deleted the azureml_mismatch branch April 24, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants