elf.c: Check e_shstrndx
against sections
' length, not capacity
#5136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_API
function and struct this PR changes.RZ_API
).Detailed description
In elf.c, this pr checks
e_shstrndx
againstsections
' length and not capacity since the former makes more sense, andsections
' length should always be less than or equal its capacity so this is a tighter bound. The original check against capacity was done byrz_vector_index_ptr()
's precondition assertion.This is a cherry-pick from #5102.
Test plan
The change makes sense. All builds are green.
Closing issues
...