Add app label to Results api deployment

[pratap0007]

This will add a app label to the Results api deployment
which will be reference in the ServiceMonitor

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Tested your changes locally (if this is a code change)
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign khrm after the PR has been reviewed.
You can assign the PR to them by writing /assign @khrm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aThorp96]

Any reason we can't reference the app.kubernetes.io/name label a service monitor?

[pratap0007]

Any reason we can't reference the app.kubernetes.io/name label a service monitor?

yes, we can refer app.kubernetes.io/name label , other existing ServiceMonitor are referencing by lable app so I thought to add this label. Shall I close the PR?

[enarha]

I'm OK either way. If all other Tekton components have that label, I'm OK to have it on Results as well as it standardize things. You should add that for each component though, not just the api, but watcher and retention-policy-agent as well. And app: tekton-results-api-controller is not strictly correct, as the api is not a controller, so it should be app: tekton-results-api. If you or other reviewers prefer to omit that extra label and use app.kubernetes.io/name, that's fine as well.

[aThorp96]

@pratap0007 where is this service monitor defined?

[pratap0007]

@pratap0007 where is this service monitor defined?
There is an operator upstream issue to add the ServiceMonitor for missing components

[aThorp96]

Suggested change

	app: tekton-results-api-controller
	app: tekton-results-api