Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass dependency indexes when running solver #624

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Pass dependency indexes when running solver #624

merged 1 commit into from
Feb 14, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Feb 9, 2022

Related Issues and Dependencies

Related: thoth-station/solver#5111
Related: thoth-station/graph-refresh-job#669
Related: thoth-station/thoth-application#2272

This introduces a breaking change

  • No

Description

Pass all registered indexes when scheduling solver workflow.

@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@sesheta
Copy link
Member

sesheta commented Feb 9, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2022
@fridex
Copy link
Contributor Author

fridex commented Feb 11, 2022

Depends on the common change. I will propagate the update once thoth-common adjustment will be released. In the meantime, PTAL

/assign @pacospace

@fridex fridex marked this pull request as ready for review February 11, 2022 10:59
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2022
pacospace
pacospace approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯 Thanks!

@sesheta
Copy link
Member

sesheta commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@sesheta sesheta merged commit 5149236 into thoth-station:master Feb 14, 2022
@fridex fridex deleted the dependency-indexes branch February 14, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacospace pacospace pacospace approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@pacospace pacospace

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @sesheta @pacospace