Skip to content

fix can not accept license when install platform28 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix can not accept license when install platform28 #15

wants to merge 1 commit into from

Conversation

hangox
Copy link

@hangox hangox commented Jan 25, 2019

new platform use new license ，when install api 28 , it show license not accept

@thyrlian
Copy link
Owner

Hi @hangox thank you for creating this PR 👍

thyrlian
thyrlian reviewed Jan 27, 2019
View reviewed changes
android-sdk/license_accepter.sh
@@ -20,9 +20,11 @@ accept_all_android_licenses() {
echo "Android licenses directory doesn't exist, creating one..."
mkdir -p $ANDROID_LICENSES
fi
accept_license_of android-sdk-license 8933bad161af4178b1185d1a37fbf41ea5269c55
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove any existing license.

thyrlian
thyrlian reviewed Jan 27, 2019
View reviewed changes
android-sdk/license_accepter.sh
@@ -20,9 +20,11 @@ accept_all_android_licenses() {
echo "Android licenses directory doesn't exist, creating one..."
mkdir -p $ANDROID_LICENSES
fi
accept_license_of android-sdk-license 8933bad161af4178b1185d1a37fbf41ea5269c55
accept_license_of android-sdk-license d56f5187479451eabf01fb78af6dfcb131a6481e
accept_license_of android-googletv-license 601085b94cd77f0b54ff86406957099ebe79c4d6、
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing punctuation which doesn't belong to the license.

thyrlian
thyrlian reviewed Jan 27, 2019
View reviewed changes
android-sdk/license_accepter.sh
accept_license_of android-sdk-license 8933bad161af4178b1185d1a37fbf41ea5269c55
accept_license_of android-sdk-license d56f5187479451eabf01fb78af6dfcb131a6481e
accept_license_of android-googletv-license 601085b94cd77f0b54ff86406957099ebe79c4d6、
accept_license_of android-sdk-license 24333f8a63b6825ea9c5514f83c2829b004d1fee
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the original order, thanks.

thyrlian
thyrlian reviewed Jan 27, 2019
View reviewed changes
android-sdk/license_accepter.sh
accept_license_of android-sdk-preview-license 84831b9409646a918e30573bab4c9c91346d8abd
accept_license_of android-sdk-preview-license 504667f4c0de7af1a06de9f4b1727b84351f2910
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any new license added here, please add a corresponding raw license file here. I have made an example for you.

In case it's an updated license, please create a new license file, with date appended to the file name. For instance: AndroidSoftwareDevelopmentKitLicenseAgreement-20190116.

thyrlian
thyrlian requested changes Jan 27, 2019
View reviewed changes
Copy link
Owner

@thyrlian thyrlian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, please apply some changes suggested in the review.

@eyal919 eyal919 mentioned this pull request Jan 27, 2019
Closed
@thyrlian
Copy link
Owner

Hi @hangox, are you still working on this PR? Please let me know. Otherwise I'll close it. Thank you very much.

@rossmckelvie rossmckelvie mentioned this pull request Feb 4, 2019
Merged
@thyrlian
Copy link
Owner

thyrlian commented Feb 4, 2019

Sorry that I have to close this PR as another PR has made requested changes. But thanks anyway.

@thyrlian thyrlian closed this Feb 4, 2019
@hangox
Copy link
Author

hangox commented Feb 5, 2019 •
edited
Loading

Sorry that I have to close this PR as another PR has made requested changes. But thanks anyway.

never mind , I am too busy, causing me to forget this. Just fix it。And I just know , it can reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thyrlian thyrlian thyrlian requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hangox @thyrlian