Skip to content

README include cmdline-tools in path to sdkmanager #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

zachawilson
Copy link
Contributor

Update README so that getting started section can be completed without incident.

Problem Solved

Following the Getting Started section of the README I run into an error because of invalid path in the step:
sdk/tools/bin/sdkmanager --update

Inspecting the directory it seems that the correct command needs the path update making the correct command be:
sdk/cmdline-tools/tools/bin/sdkmanager --update

Specifically these are the lines I ran into.

AndroidSDK/README.md

Lines 129 to 135 in 3d788b2

# copy the pre-downloaded SDK to the mounted 'sdk' directory
docker run -it --rm -v $(pwd)/sdk:/sdk thyrlian/android-sdk bash -c 'cp -a $ANDROID_SDK_ROOT/. /sdk'
# go to the 'sdk' directory on the host, update the SDK
# ONLY IF the host machine is the same target architecture as the container
# JDK required on the host
sdk/tools/bin/sdkmanager --update

I believe all of the other places this PR updates are appropriate changes too.

@thyrlian
Copy link
Owner

Thanks mate!

My bad, I thought I had already updated the README as part of this change, but it turned out not at all.

Copy link
Owner

@thyrlian thyrlian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thyrlian thyrlian merged commit 33e92ea into thyrlian:master Jul 23, 2021
@thyrlian
Copy link
Owner

I also made this minor change after merging your PR.
7c3778e

I didn't touch platform-tools, because it resides in ANDROID_SDK_ROOT, on the same level as cmdline-tools.

@zachawilson zachawilson deleted the patch-1 branch July 23, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants