fix: Remove Uno.UI.Reference from Skia slnf #18535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18535/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18535/index.html |
jeromelaban
approved these changes
Oct 22, 2024
ajpinedam
approved these changes
Oct 22, 2024
Youssef1313
reviewed
Oct 23, 2024
| @@ -54,7 +54,6 @@ | |||
| "Uno.UI.Toolkit\\Uno.UI.Toolkit.Skia.csproj", | |||
| "Uno.UI.XamlHost.Skia.Wpf\\Uno.UI.XamlHost.Skia.Wpf.csproj", | |||
| "Uno.UI.XamlHost\\Uno.UI.XamlHost.Skia.csproj", | |||
| "Uno.UI\\Uno.UI.Reference.csproj", | |||
There was a problem hiding this comment.
This is supposed to be problematic. Have you tried a local build for the whole solution inside Visual Studio?
There was a problem hiding this comment.
Oh, it's not yet required on current master, but it will be required by the way #18216 is doing the packaging.
There was a problem hiding this comment.
Then I guess we will need to add Uno.Reference and Uno.Foundation.Reference as well, otherwise VS complains about missing types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):