Drop jzlib dependency
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally `jzlib` depdency was added to support defalte decompression, this library was optional in netty: https://github.com/lightbody/browsermob-proxy/pull/225/files. Over time JDK zlib decompression support was added to netty: netty/netty#1481. And then this implemnetation became default: netty/netty#4707. It makes `jzlib` dependency redundant, as JDK based implmentation is used. If someone needs to use `jzlib` dependency, then it's required to set the corresponding netty flag and to add this library explicitly to the local project dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally
jzlibdepdency was added to support defalte decompression, this library was optional in netty: https://github.com/lightbody/browsermob-proxy/pull/225/files.Over time JDK zlib decompression support was added to netty: netty/netty#1481. And then this implemnetation became default: netty/netty#4707.
It makes
jzlibdependency redundant, as JDK based implmentation is used. If someone needs to usejzlibdependency, then it's required to set the corresponding netty flag and to add this library explicitly to the local project dependencies.