Skip to content

Updated to NX 20.5.0 and Angular to 19.2.1 #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

anthonysdj
Copy link

@anthonysdj anthonysdj commented Mar 8, 2025

This PR updates Nx to v20.5.0 and Angular to v19.2.1.

  • Upgraded Nx to version 20.5.0.
    
  • Upgraded Angular to version 19.2.1.
    
  • Add tests (in modules/ng2-dragula/src/spec/...) for any code you have changed

  • Make sure the test suite passes

  • Make sure the demo app isn't broken

@rohanahata
Copy link

@anthonysdj this is ready right? Can we have @valorkin to approve this, so that we can get it merged.

@anthonysdj
Copy link
Author

@rohanahata Yep this is ready to merge.

@RahulPatilFullStack
Copy link

@anthonysdj
We are using the ng2-dragula library in our project. However, after upgrading to Angular version 19, we are facing issues because ng2-dragula does not support Angular 19. Could you please provide an update on when issue #1113 will be merged and the final version will be released?

Thank you!

@RahulPatilFullStack
Copy link

@iamishver , @valorkin, @rohanahata
The pull request failed so can you please check on that and update it so that final version is ready, As we are using it in our project its kind of urgent so can anybody resolve the issue ASAP.

"version": "5.1.0",
"description": "Simple drag and drop with dragula",
"version": "5.1.1",
"description": "Fork of ng2-dragula updated to angular version 19",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't really a fork after it being merged, I guess?

Additionally, I'd argue a major Angular update would warrant more than a patch version increase. WDYT?

Comment on lines +34 to +36
"@angular/animations": ">=16.0.0 <20.0.0",
"@angular/core": ">=16.0.0 <20.0.0",
"@angular/common": ">=16.0.0 <20.0.0"
Copy link

@pmaieref pmaieref Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too familiar with the project (and would use it with Angular 18+), but is it verified to still be compatible with Angular 16/17/18...? Just to make sure...

Copy link

@EdwardIII EdwardIII Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my .02 (sorry, dropping in uninvited :), standalone modules were introduced back in v14 and that seems to really be the only change in this PR, so if ng2-dragula worked before this change on v16, 17 + 18, then it should work afterwards too

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Yes, this package works fine in v16, v17, and v18. It also works with v19; the only issue is that npm issues an error saying the Angular version is not compatible during installation. You can bypass this by using npm i --force. I believe this change is the only thing needed for it to work properly.

@RahulPatilFullStack
Copy link

@anthonysdj @rohanahata @valorkin @iamishver
Could anyone please provide an update on the ng2-dragula pipeline installation failure, including when the issues are expected to be resolved and the final version will be ready for use? Additionally, please share the timeline for when will be the final version be ready with latest version.

@rohanahata
Copy link

@RahulPatilFullStack -- No one is really obligated to answer these questions. That being said, we can politely request @valorkin and his team, to help us out.

@RahulPatilFullStack
Copy link

@valorkin
Can you please help us out to resolve this issue and make a final version ready?

@pavanshinde47
Copy link

Can anyone fix the issue and merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants