-
Notifications
You must be signed in to change notification settings - Fork 434
Updated to NX 20.5.0 and Angular to 19.2.1 #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- angular code 17.1.3
- set stand alone to false
@anthonysdj this is ready right? Can we have @valorkin to approve this, so that we can get it merged. |
@rohanahata Yep this is ready to merge. |
@anthonysdj Thank you! |
@iamishver , @valorkin, @rohanahata |
"version": "5.1.0", | ||
"description": "Simple drag and drop with dragula", | ||
"version": "5.1.1", | ||
"description": "Fork of ng2-dragula updated to angular version 19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't really a fork after it being merged, I guess?
Additionally, I'd argue a major Angular update would warrant more than a patch version increase. WDYT?
"@angular/animations": ">=16.0.0 <20.0.0", | ||
"@angular/core": ">=16.0.0 <20.0.0", | ||
"@angular/common": ">=16.0.0 <20.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too familiar with the project (and would use it with Angular 18+), but is it verified to still be compatible with Angular 16/17/18...? Just to make sure...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my .02 (sorry, dropping in uninvited :), standalone modules were introduced back in v14 and that seems to really be the only change in this PR, so if ng2-dragula worked before this change on v16, 17 + 18, then it should work afterwards too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Yes, this package works fine in v16, v17, and v18. It also works with v19; the only issue is that npm issues an error saying the Angular version is not compatible during installation. You can bypass this by using npm i --force
. I believe this change is the only thing needed for it to work properly.
@anthonysdj @rohanahata @valorkin @iamishver |
@RahulPatilFullStack -- No one is really obligated to answer these questions. That being said, we can politely request @valorkin and his team, to help us out. |
@valorkin |
Can anyone fix the issue and merge this pull request? |
This PR updates Nx to v20.5.0 and Angular to v19.2.1.
Add tests (in
modules/ng2-dragula/src/spec/...
) for any code you have changedMake sure the test suite passes
Make sure the demo app isn't broken