Skip to content

fix: Fix getStreamingNetworkErrorMetadata to support videojs 7 #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

idsulik
Copy link

@idsulik idsulik commented Feb 10, 2025

Description

#1566

Specific Changes proposed

Added property existing checking to avoid exception if you use 7th version of the videojs

Requirements Checklist

  • Bug fixed
  • Reviewed by Two Core Contributors

Copy link

welcome bot commented Feb 10, 2025

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.99%. Comparing base (1e721c1) to head (d525752).

Files with missing lines Patch % Lines
src/error-codes.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   84.00%   83.99%   -0.01%     
==========================================
  Files          44       44              
  Lines       11707    11709       +2     
  Branches     2623     2624       +1     
==========================================
+ Hits         9834     9835       +1     
- Misses       1873     1874       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@idsulik
Copy link
Author

idsulik commented Apr 3, 2025

@mister-ben @gkatsev hi! Is there anything I can do to push the changes?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants