-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browser): allow for pretty-format
as a sibling dependency
#4590
fix(browser): allow for pretty-format
as a sibling dependency
#4590
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
|
pretty-format
as a sibling dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this manually by patching node_modules
using the linked minimal reproduction.
It also looks like this issue doesn't come up with pnpm
. The vitest-tests repository has a browser setup with pnpm
only: https://github.com/vitest-tests/browser-simple. As Vitest's main repository (this project) is using pnpm
it's difficult to create failing test cases here. Maybe we'll need vitest-tests/browser-simple-npm
.
I have no idea if that would work or not, but have you ever thought of maybe using corepack for some tests or a workflow? I never personally use corepack myself, but I was wondering if it could help here or not? Maybe this GitHub Action |
@sheremet-va sorry to bother you, but any chance you could cut another beta release for this fix? |
Description
Solves #4570 by adding a missing dependency of
@vitest/snapshot
to the dependency optimization.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.