[WIP] Optional drivedb and other small changes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthriller
force-pushed
the
optional-drivedb
branch
3 times, most recently
from
edcdd32 to
0e51bb0
Compare
…also, make ata_pass_through_16() respect said `dir` argument
…y thing here; use 'info' for other warning formatting options instead
…ata for future reference
…le also fixing future compilation error
warning[E0503]: cannot use `*dir` because it was mutably borrowed
--> src/scsi/linux.rs:69:5
|
57 | let mut data = if let Direction::From(buf) = dir {
| --- borrow of `dir.0` occurs here
...
69 | Direction::None => -1,
| ^^^^^^^^^^^^^^^ use of borrowed `dir.0`
...
73 | dxferp: match data {
| ---- borrow later used here
|
= warning: this error has been downgraded to a warning for backwards compatibility with previous releases
= warning: this represents potential undefined behavior in your code and this warning will become a hard error in the future
…tead of cloned String)
…parate conditional impl around
…ack into the main impl
vthriller
force-pushed
the
optional-drivedb
branch
from
0e51bb0 to
19e21f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see also TODOes mentioned in commit msgs)