added uno support #122
added uno support #122
Conversation
| <Nullable>enable</Nullable> | ||
| <UseWinUI>true</UseWinUI> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <DisableImplicitUnoPackages>true</DisableImplicitUnoPackages> |
There was a problem hiding this comment.
Would you recall why you needed to add this line?
There was a problem hiding this comment.
I added this to remove unwanted dependencies. my main concern was Uno.WinUI in case of net8.0-windows.
There was a problem hiding this comment.
Got it! Most of those dependencies are dev-time only, they won't appear in your packages.
| net8.0-desktop; | ||
| net8.0; | ||
| net8.0-maccatalyst; | ||
| net8.0-windows10.0.26100; | ||
| net8.0-browserwasm; |
There was a problem hiding this comment.
Noticed we aren't including android/ios tfms
It may work nicely on mobile as well under certain circumstances. Could be interesting to add them and see how it behaves in the sample app
There was a problem hiding this comment.
I did that intentionally cause TableView is not made for small screens. I tried it on android and that wasn't good. I'll try to make it available for small screens in 1.4 hopefully.
| <ItemGroup> | ||
| <PackageReference Include="CommunityToolkit.WinUI.Behaviors" Version="8.1.240916" /> | ||
| <PackageReference Condition="'$(TargetFramework)' == 'net8.0-windows10.0.26100'" Include="Microsoft.WindowsAppSDK" Version="1.6.250108002" /> | ||
| <PackageReference Condition="'$(TargetFramework)' != 'net8.0-windows10.0.26100'" Include="Uno.WinUI" Version="5.5.95" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
This shouldn't™ be needed, I believe as long as we can remove the <DisableImplicitUnoPackages>true</DisableImplicitUnoPackages> from Jerome's comment
|
@jeromelaban @kazo0 can you guys help me to remove this build warning? |
Yes this issue is all too familiar. We have been discussing it recently. Uno currently does not support the We are currently investigating a way of implementing it in a "lightweight" type of way, without all the complexity that is needed for a true implementation. (Issue here: unoplatform/uno#19707) This also explains the visual difference for things like the selection state on the TableView rows. You can see on Uno platforms it is missing the vertical blue rectangle to denote the selected row, as well as uses a different color for the selected background. (Screenshots taken from two separate apps, so don't worry about the content not being the same) Windows (WinAppSDK):
Uno (net9.0-desktop on Windows)
I believe the best option for now would be to avoid using Let me know if you need any help with that. I will keep you posted on the status of the minimal ListViewItemPresenter implementation. |
|
I tested it on WASM, desktop, and WinUI, it works fine. The warning only appears with net8.0; all other frameworks build without this warning. Maybe I can leave it as it is for now and let it be tested by the community. If someone complains, then I'll think about it. |
Added Uno Platform Support
This PR adds Uno Platform support to WinUI.TableView, enabling compatibility with WebAssembly, macOS, and Linux.
Note: