Implement getMetadata for remaining Passive scripts
#455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Jun 26, 2024
passive/SQL injection detection.js
Outdated
Comment on lines
75
to
77
| let comm; | ||
| while ((comm = sqlImpl.regex.exec(body))) { | ||
| found.push(comm[0]); |
There was a problem hiding this comment.
Did this come from one of the comment scripts?
There was a problem hiding this comment.
If so, think it's worth renaming more meaningfully?
There was a problem hiding this comment.
I combined all the individual checks into a single loop. Do you mean renaming the found variable? Maybe foundSqlErrors?
There was a problem hiding this comment.
Sorry I meant the “comm” array
There was a problem hiding this comment.
Ugh I didn't realize how many times this had been copied. Anyway thanks for fixing this one. It seems that people have repeated use of comm[] all over the place 😉
thc202
reviewed
Jun 28, 2024
ricekot
force-pushed
the
passive-scripts-metadata
branch
from
a14a25f to
1718237
Compare
kingthorin
approved these changes
Jun 29, 2024
thc202
reviewed
Jun 29, 2024
Update the following scripts to implement the `getMetadata()` function: - passive/Server Header Disclosure.js - passive/SQL injection detection.js - passive/Telerik Using Poor Crypto.js - passive/Upload form discovery.js - passive/X-Powered-By_header_checker.js Update evidence / otherInfo fields for: - passive/clacks.js - passive/CookieHTTPOnly.js Don't add "Other instances:" or "Other values:" to otherInfo if there are none. Signed-off-by: ricekot <[email protected]>
ricekot
force-pushed
the
passive-scripts-metadata
branch
from
1718237 to
027f938
Compare
thc202
approved these changes
Jun 30, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the following scripts to implement the
getMetadata()function:Also update evidence / otherInfo fields for:
Part of #440.