support cloudbox #1355
Merged
support cloudbox #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
YunZZY
reviewed
May 8, 2025
lib/common/signUtils.js
Outdated
| * @param {string} region | ||
| * @return {string} | ||
| */ | ||
| exports.getSignRegion = function getSignRegion(cloudBoxId, region) { |
There was a problem hiding this comment.
js没有必填概念吧，都要填的，只不过cloudBoxId为undefined
There was a problem hiding this comment.
遵守函数定义的规范，你的JS doc写的是{string} [cloudBoxId]，可选项放在前面了，如果两个都是必填，cloudBoxId的类型要增加undefined，且不能是可选
lib/common/signUtils.js
Outdated
| * @returns {string} | ||
| */ | ||
| exports.getStringToSign = function getStringToSign(region, date, canonicalRequest) { | ||
| exports.getStringToSign = function getStringToSign(region, date, canonicalRequest, product) { |
There was a problem hiding this comment.
product改成可选项，product = 'oss'，下面就不用写product || 'oss'了
| @@ -138,6 +137,9 @@ describe('test/bucket.test.js', () => { | |||
| assert.equal(result.bucket.IntranetEndpoint, `${config.region}-internal.aliyuncs.com`); | |||
| assert.equal(result.bucket.AccessControlList.Grant, 'private'); | |||
| assert.equal(result.bucket.StorageClass, 'Standard'); | |||
|
|
|||
| assert.equal(result.bucket.AccessControlList.Grant, 'private'); | |||
test/node/object.test.js
Outdated
| @@ -1086,6 +1083,9 @@ describe('test/object.test.js', () => { | |||
| }); | |||
|
|
|||
| describe('signatureUrl(), asyncSignatureUrl() and signatureUrlV4()', () => { | |||
| before(function () { | |||
| if (store.options.cloudBoxId) this.skip(); // 云盒不支持url签名 | |||
test/node/object.test.js
Outdated
| @@ -2626,6 +2634,9 @@ describe('test/object.test.js', () => { | |||
| }); | |||
|
|
|||
| describe('calculatePostSignature()', () => { | |||
| before(function () { | |||
| if (store.options.cloudBoxId) this.skip(); // 云盒只支持head v4签名 | |||
test/node/signature.test.js
Outdated
| ]); | ||
| }); | ||
| it(`should authorizationV4 support ${isCloudBox ? 'cloudBox' : 'publicCloud'}`, async () => { | ||
| sinon.restore(); |
test/node/sts.test.js
Outdated
| @@ -87,9 +81,10 @@ describe('test/sts.test.js', () => { | |||
| const stsClient = sts(stsConfig); | |||
| let result = await stsClient.assumeRole(stsConfig.roleArn); | |||
| assert.strictEqual(result.res.status, 200); | |||
|
|
|||
| console.log(stsConfig.bucket); | |||
There was a problem hiding this comment.
console.log这个没有配置eslint吗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.