Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support cloudbox #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support cloudbox #1355
Changes from 20 commits
d67722a
ebf6245
335f852
d5847f5
50b51ad
1eafbef
b01e699
63ef66a
ceb0071
5b16100
66894ec
b6ba6f8
03da61c
d902596
7595afc
3f7829e
219c8ae
5d21db5
f0decdd
3086407
b39f866
d23d622
cebed7b
7e8d8ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
必填项在前,可选项在后
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js没有必填概念吧,都要填的,只不过cloudBoxId为undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
遵守函数定义的规范,你的JS doc写的是{string} [cloudBoxId],可选项放在前面了,如果两个都是必填,cloudBoxId的类型要增加undefined,且不能是可选
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
product改成可选项,product = 'oss',下面就不用写product || 'oss'了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.