Skip to content

FifoPlayer: Make functions static #13603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FifoPlayer: Make functions static #13603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Core/Core/FifoPlayer/FifoDataFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ FifoDataFile::FifoDataFile() = default;

FifoDataFile::~FifoDataFile() = default;

bool FifoDataFile::ShouldGenerateFakeVIUpdates() const
bool FifoDataFile::ShouldGenerateFakeVIUpdates()
{
return true;
}
Expand Down
4 changes: 2 additions & 2 deletions Source/Core/Core/FifoPlayer/FifoDataFile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class FifoDataFile
void SetIsWii(bool isWii);
bool GetIsWii() const;
bool HasBrokenEFBCopies() const;
bool ShouldGenerateFakeVIUpdates() const;
static bool ShouldGenerateFakeVIUpdates();

u32* GetBPMem() { return m_BPMem.data(); }
u32* GetCPMem() { return m_CPMem.data(); }
Expand All @@ -85,7 +85,7 @@ class FifoDataFile
FLAG_IS_WII = 1
};

void PadFile(size_t numBytes, File::IOFile& file);
static void PadFile(size_t numBytes, File::IOFile& file);

void SetFlag(u32 flag, bool set);
bool GetFlag(u32 flag) const;
Expand Down
4 changes: 2 additions & 2 deletions Source/Core/Core/FifoPlayer/FifoPlayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ class FifoPlayer
void LoadXFReg(u16 reg, u32 value);
void LoadXFMem16(u16 address, const u32* data);

bool ShouldLoadBP(u8 address);
bool ShouldLoadXF(u8 address);
static bool ShouldLoadBP(u8 address);
static bool ShouldLoadXF(u8 address);

bool IsIdleSet() const;
bool IsHighWatermarkSet() const;
Expand Down