Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix scalar data issue in plugin settings #256

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

slessans
Copy link
Contributor

@slessans slessans commented Dec 21, 2023

For some reason when loading the config during plugin execution, ScalarData has already been converted which causes this code to throw an error. I added a check to take the ScalarData as is if it has already been converted.

Update: this seems to only happen when using ariadne_codegen.contrib.extract_operations.ExtractOperationsPlugin

Copy link
Contributor

@mat-sop mat-sop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, it looks like the issue is that in this method we are directly modifying the argument config_dict. Instead of the proposed check, I would rather see a change that leaves the dict unmodified after the first call (for example by working on a copy)

@slessans
Copy link
Contributor Author

@mat-sop updated!

@rafalp rafalp merged commit 5ca5a95 into mirumee:main Jan 19, 2024
4 checks passed
@rafalp
Copy link
Contributor

rafalp commented Jan 19, 2024

Thank you!

rafalp added a commit that referenced this pull request Jan 19, 2024
rafalp added a commit that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants